Skip to content

Fix minmax normalizer handling of single-doc result sets #128689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2025
Merged

Fix minmax normalizer handling of single-doc result sets #128689

merged 4 commits into from
Jun 2, 2025

Conversation

@Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented May 30, 2025

There is a bug in the minmax normalizer logic that causes it to return the unnormalized score when handling a single-doc result set. This PR fixes the bug and adds a YAML test for the fix.

@Mikep86 Mikep86 requested a review from pmpailis May 30, 2025 17:28
@Mikep86 Mikep86 added >bug :Search/Search Search-related issues that do not fall into other categories auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 v9.0.3 v8.18.3 labels May 30, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label May 30, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 30, 2025

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 30, 2025

Hi @Mikep86, I've created a changelog YAML for you.

pmpailis
pmpailis approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@pmpailis pmpailis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛

@Mikep86 Mikep86 merged commit adda402 into elastic:main Jun 2, 2025
18 checks passed
@Mikep86 Mikep86 mentioned this pull request Jun 2, 2025
Merged
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Jun 2, 2025
@Mikep86
Fix minmax normalizer handling of single-doc result sets (elastic#128689
885da1a 
)
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 2, 2025

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts
✅ 9.0
❌ 8.18 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 128689

@Mikep86 Mikep86 mentioned this pull request Jun 2, 2025
Merged
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Jun 2, 2025
@Mikep86
Fix minmax normalizer handling of single-doc result sets (elastic#128689
5b1a4a9 
)

(cherry picked from commit adda402)

# Conflicts:
#	x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/RankRRFFeatures.java
@Mikep86
Copy link
Contributor Author

Mikep86 commented Jun 2, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19
✅ 8.18

Questions ?

Please refer to the Backport tool documentation

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Jun 2, 2025
@Mikep86
Fix minmax normalizer handling of single-doc result sets (elastic#128689
7511e0f 
)

(cherry picked from commit adda402)

# Conflicts:
#	x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/RankRRFFeatures.java
@Mikep86 Mikep86 mentioned this pull request Jun 2, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jun 2, 2025
@Mikep86
Fix minmax normalizer handling of single-doc result sets (#128689) (#…
97d0821 
…128751)
elasticsearchmachine pushed a commit that referenced this pull request Jun 2, 2025
@Mikep86
Fix minmax normalizer handling of single-doc result sets (#128689) (#…
b536e98 
…128754)

(cherry picked from commit adda402)

# Conflicts:
#	x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/RankRRFFeatures.java
elasticsearchmachine pushed a commit that referenced this pull request Jun 2, 2025
@Mikep86
Fix minmax normalizer handling of single-doc result sets (#128689) (#…
19645fd 
…128756)

(cherry picked from commit adda402)

# Conflicts:
#	x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/RankRRFFeatures.java
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 3, 2025
@Mikep86 @mridula-s109
Fix minmax normalizer handling of single-doc result sets (elastic#128689
35c2132 
)
joshua-adams-1 pushed a commit to joshua-adams-1/elasticsearch that referenced this pull request Jun 3, 2025
@Mikep86 @joshua-adams-1
Fix minmax normalizer handling of single-doc result sets (elastic#128689
ebdfc4f 
)
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/elasticsearch that referenced this pull request Jun 5, 2025
@Mikep86 @Samiul-TheSoccerFan
Fix minmax normalizer handling of single-doc result sets (elastic#128689
90f0883 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmpailis pmpailis pmpailis approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending >bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.18.3 v8.19.0 v9.0.3 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mikep86 @elasticsearchmachine @pmpailis